Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.3.4] Fix compatibility with FFmpeg 5.1 #10862

Merged
merged 1 commit into from
Sep 3, 2022
Merged

[2.3.4] Fix compatibility with FFmpeg 5.1 #10862

merged 1 commit into from
Sep 3, 2022

Conversation

uklotzde
Copy link
Contributor

@uklotzde uklotzde commented Sep 2, 2022 •
edited
Loading

Needed to keep Mixxx working in Fedora 37:

If someone wants to improve the awkward and brittle C-style memory management of AVChannelLayout using RAII please do so later. I won't.

@uklotzde
Copy link
Contributor Author

uklotzde commented Sep 2, 2022

@Holzhaus Please verify.

@uklotzde uklotzde changed the title Fix compatibility with FFmpeg 5.1 [2.3.4] Fix compatibility with FFmpeg 5.1 Sep 3, 2022
@Holzhaus
Copy link
Member

Holzhaus commented Sep 3, 2022

Thanks, works like a charm. For building with -DWARNINGS_FATAL=ON, I also had to incorporate this unrelated fix: #10863

@Holzhaus Holzhaus added changelog This PR should be included in the changelog soundsource labels Sep 3, 2022
@Holzhaus Holzhaus merged commit 6926695 into mixxxdj:2.3 Sep 3, 2022
@Holzhaus Holzhaus added this to the 2.3.4 milestone Sep 3, 2022
@uklotzde uklotzde deleted the ffmpeg-5.1 branch September 3, 2022 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
changelog This PR should be included in the changelog soundsource
Projects
None yet
Milestone
2.3.4
Development

Successfully merging this pull request may close these issues.
2 participants
@uklotzde @Holzhaus